Merge pull request #39 from puls200/hotfix/20240827puls2002024-08-28 10:24:21 +0200
1be7d68f5cparticipant flag also resolved
Max Metz
2024-08-27 21:16:49 +0200
cc2a54c1c6added extensive logging for an open, unresolved issue. The issue-log may make clear, where the issue originates
Max Metz
2024-08-27 21:14:30 +0200
e1d9570268solving the concatenation issue of a list and a None-type.
Max Metz
2024-08-27 20:52:10 +0200
8082100b7eusing the @classmethod _missing_ function in an IntFlag creates an incorrect resolution of intflags. 127 was resolved as 0 due to the _missing_ function. Without that method, 127 becomes a proper multi-flag
Max Metz
2024-08-27 20:33:33 +0200
6eab98d2a1correcting the issue with participant_id authorization (BSMD or AGENCY check).
Max Metz
2024-08-27 19:23:37 +0200
Merge pull request #38 from puls200/hotfix/api_input_validation_20240812puls2002024-08-15 08:47:06 +0200
fcc03b2adeadaptation of traffic validation (resolving open issue)
Max Metz
2024-08-14 19:09:35 +0200
c4e5764601/ships GET no longer blocks deleted ships from being returned.
Max Metz
2024-08-14 15:53:37 +0200
b60874cbb0shipcall, ship, times and user verify the validity of JSON data when receiving POST/PUT requests.
Max Metz
2024-08-14 15:49:28 +0200
e488501837debugging the missing column '.PORT_ADMINISTRATION' issue
Max Metz
2024-08-14 14:58:03 +0200
4f3686e00fmarshmallow.fields incorrectly resolved the 'required' field. Adapted each field to ensure that missing data properly raises an error.
Max Metz
2024-08-14 13:59:26 +0200
Merge pull request #37 from puls200/hotfix/api_input_validation_20240812puls2002024-08-13 08:28:19 +0200
cdf6e7d99bReverted change to only return not deleted shipsDaniel Schick2024-08-13 08:27:05 +0200
0e8faf499dGET ships no longer returns deleted ships
Max Metz
2024-08-12 20:35:37 +0200
22009eb469resolving an issue where missing values for 'flags' in the Shipcall would cause rule-violations
Max Metz
2024-08-12 19:56:26 +0200
e526337c6aadded a reference check to PUT-requests (shipcall), so each provided ID must exist. Corrected some input validation functions to solve known bugs
Max Metz
2024-08-12 19:43:19 +0200
Merge pull request #36 from puls200/hotfix/20240806_api_validationpuls2002024-08-06 21:54:42 +0200
d54fed9160corrected open issues of the API validation functions. Made some validation errors more verbose, improved robustness, refactored some of the methods and adapted many unit tests to the novel format.
Max Metz
2024-08-06 20:46:40 +0200
ea028f6d73resolving conflicts after rebasing. This simply originated from the remote branch of the PR converging from the develop branch.
feature/notifier_squashed
Max Metz
2024-08-01 18:21:21 +0200
40e7a4b3afCreated an HTML-based Email notification template, which is adaptive to error messages. It includes a logo file from the local repository (logo_bremen_calling.png). Refactoring methods and clearing old methods. Created a one-line function to connect to the Email server. Included the Notifier's sending method in the routine will be executed every 15 minutes and includes those shipcalls, which have been evaluated at least 10 minutes ago. Located the logo file and email template in a resources/ folder within the library. Manually overwriting the Emailaddress of all notification recipients, so the BSMD mail is used throughout testing.
Max Metz
2024-07-31 19:01:17 +0200
8060b0ee30building out and preparing the EmailHandler's adaptive content. Using HTML formatting.
Max Metz
2024-07-30 11:41:46 +0200
979804f8ccremoved a comment. Notification types in the User's schema will remain booleans (email, whatsapp, signal, popup). Daniel clarified that some time ago.
Max Metz
2024-06-10 09:03:35 +0200
36b6173b36Created Notifier object, which provides the logic to create notifications and issue them to the respective users, depending on the type of notification they have selected. Building the skeleton, where the methods will be filled functionally soon. Adapted the History-schema.
Max Metz
2024-06-10 08:09:51 +0200
Merge pull request #30 from puls200/feature/api_input_validationpuls2002024-08-01 14:27:42 +0200
e1a623ab41Created an HTML-based Email notification template, which is adaptive to error messages. It includes a logo file from the local repository (logo_bremen_calling.png). Refactoring methods and clearing old methods. Created a one-line function to connect to the Email server. Included the Notifier's sending method in the routine will be executed every 15 minutes and includes those shipcalls, which have been evaluated at least 10 minutes ago. Located the logo file and email template in a resources/ folder within the library. Manually overwriting the Emailaddress of all notification recipients, so the BSMD mail is used throughout testing.
Max Metz
2024-07-31 19:01:17 +0200
63040c7f21building out and preparing the EmailHandler's adaptive content. Using HTML formatting.
Max Metz
2024-07-30 11:41:46 +0200
ad1e0249d7removed a comment. Notification types in the User's schema will remain booleans (email, whatsapp, signal, popup). Daniel clarified that some time ago.
Max Metz
2024-06-10 09:03:35 +0200
09f6f247a1Created Notifier object, which provides the logic to create notifications and issue them to the respective users, depending on the type of notification they have selected. Building the skeleton, where the methods will be filled functionally soon. Adapted the History-schema.
Max Metz
2024-06-10 08:09:51 +0200
0a17d9b220Added input validation for API requests. Refactored some methods, added docstrings. Solved marshmallow-warnings in BreCal.schemas.model. Added unit tests, now totaling 215. Added proposals to refactor all SQL queries into an object at BreCal.database.sql_queries.SQLQuery for better standardization. Created a helper-object to handle Emails, which prepares the notification-feature.
Max Metz
2024-06-10 07:27:58 +0200
ed7d04b584Merge branch 'feature/notifier' of github.com:puls200/brecal into feature/notifier
feature/notifier
Max Metz
2024-07-31 18:59:07 +0200
d8d75afc6bCreated an HTML-based Email notification template, which is adaptive to error messages. It includes a logo file from the local repository (logo_bremen_calling.png). Refactoring methods and clearing old methods. Created a one-line function to connect to the Email server. Included the Notifier's sending method in the routine will be executed every 15 minutes and includes those shipcalls, which have been evaluated at least 10 minutes ago. Located the logo file and email template in a resources/ folder within the library. Manually overwriting the Emailaddress of all notification recipients, so the BSMD mail is used throughout testing.
Max Metz
2024-07-31 18:58:39 +0200
b9df88b34arefactoring: provided a more understandable variant of the notifier. Will create a BPMN-diagram to depict the process soon.
Max Metz
2024-07-31 18:37:51 +0200
267b53aa91resolving conflicts between the PR (remote version of feature/notifier) and feature/notifier.
Max Metz
2024-07-31 17:05:08 +0200
982420dd34properly integrating validation rules 0005A and 0005B, which consider the amount of similar shipcall times (eta&etd)
Max Metz
2024-07-31 16:59:30 +0200
be14e3ee1aincluding evaluation_times and evaluation_notifications_sent
Max Metz
2024-07-31 16:38:05 +0200
2485a894a1again, overwriting the previous email assignment. Unless the testing phase is completed, no mails shall be sent to users except for the test-mail of bsmd
Max Metz
2024-07-31 15:32:48 +0200
e2c532bd64instead of overwriting the recipient's addresses, the bsmd address will simply (always) be added to the list of recipients.
Max Metz
2024-07-31 15:30:06 +0200
1f4dd21f3cmanually overwritting the email address of all recipients of an Email notification with the proxy-mail 'bremencalling@bsmd.de'. This is useful to test the feature before enabling it to the live-system.
Max Metz
2024-07-31 15:18:47 +0200
4848df4d7ethe evaluation function (traffic-light validation) additionally performs the notification function to generate notifications. Integrated within the scheduler.
Max Metz
2024-07-31 14:13:41 +0200
431608cd62refactored the account-data of the Email-server, so it can be easily adapted later on. Decoupled into a novel file notifications/accounts.py with some simple unit tests.
Max Metz
2024-07-31 12:30:37 +0200
9709b06196creating only one notification per notification_type, even if multiple users request the same notification_type.
Max Metz
2024-07-31 12:05:48 +0200
bc6d391094relocating logo_bremen_calling.png and default_email_template to a novel folder in the library: resources. Adapted the dynamic path functions in the library. Created tests, which assert, when the files are missing. Relocating functions from stubs/email_template.py to the email_handling.py to avoid confusion.
Max Metz
2024-07-31 11:49:44 +0200
9efabf6367found the bremen_calling_logo.png file within the client's resources. Mapping towards that file when creating email notifications. This alleviates an additional dependency.
Max Metz
2024-07-31 09:04:35 +0200
2ea37bde56adding the Notifier to schedule routines with an execution routine of 15 minutes. Notifications must be at least 10 minutes old and still relevant to be sent.
Max Metz
2024-07-31 08:35:40 +0200
4b7a098286included the Notifier in the routine. Will be executed every 15 minutes for notifications, which are at least 10 minutes old.
Max Metz
2024-07-31 08:28:44 +0200
8cd6afbb69clearing older methods of the Notifier class. There is now a one-line function, which connects to the Email-server, populates candidates for notifications, creates those notifications one-by-one and sends them. Finally, the database is updated, so a notification is sent only once.
Max Metz
2024-07-30 17:43:17 +0200
f344588f89creating an HTML Email template for notifications, which includes a logo file (#TODO: store logo within BreCal git). Built out most of the Notifier. Provided suitable SQLQueries and updated the EmailHandler.
Max Metz
2024-07-30 17:20:51 +0200
7c546f5ab7building out and preparing the EmailHandler's adaptive content. Using HTML formatting.
Max Metz
2024-07-30 11:41:46 +0200
84a93646d9removed a comment. Notification types in the User's schema will remain booleans (email, whatsapp, signal, popup). Daniel clarified that some time ago.
Max Metz
2024-06-10 09:03:35 +0200
ab0b69f337Created Notifier object, which provides the logic to create notifications and issue them to the respective users, depending on the type of notification they have selected. Building the skeleton, where the methods will be filled functionally soon. Adapted the History-schema.
Max Metz
2024-06-10 08:09:51 +0200
e10e9ef88bAdded input validation for API requests. Refactored some methods, added docstrings. Solved marshmallow-warnings in BreCal.schemas.model. Added unit tests, now totaling 215. Added proposals to refactor all SQL queries into an object at BreCal.database.sql_queries.SQLQuery for better standardization. Created a helper-object to handle Emails, which prepares the notification-feature.
Max Metz
2024-06-10 07:27:58 +0200
32692ea93aadding evaluation_time to the evaluate_shipcall_state function (traffic light validation). This was previously not implemented.
feature/evaluation_times
Max Metz
2024-07-31 15:55:35 +0200
29b611c780instead of overwriting the recipient's addresses, the bsmd address will simply (always) be added to the list of recipients.
Max Metz
2024-07-31 15:30:06 +0200
0d13ffd626manually overwritting the email address of all recipients of an Email notification with the proxy-mail 'bremencalling@bsmd.de'. This is useful to test the feature before enabling it to the live-system.
Max Metz
2024-07-31 15:18:47 +0200
5769889fearesolving the validation issue in shipcalls, which was caused by a faulty fields type in the ShipcallSchema.
Max Metz
2024-07-31 14:59:59 +0200
0de0baf1d4the evaluation function (traffic-light validation) additionally performs the notification function to generate notifications. Integrated within the scheduler.
Max Metz
2024-07-31 14:13:41 +0200
b078386520refactored the account-data of the Email-server, so it can be easily adapted later on. Decoupled into a novel file notifications/accounts.py with some simple unit tests.
Max Metz
2024-07-31 12:30:37 +0200
0de47e2627creating only one notification per notification_type, even if multiple users request the same notification_type.
Max Metz
2024-07-31 12:05:48 +0200
fae07bdadfrelocating logo_bremen_calling.png and default_email_template to a novel folder in the library: resources. Adapted the dynamic path functions in the library. Created tests, which assert, when the files are missing. Relocating functions from stubs/email_template.py to the email_handling.py to avoid confusion.
Max Metz
2024-07-31 11:49:44 +0200
e59f371525getlatest returns ships & shipcalls. 'Times' has been removed as a simplification.
feature/get_latest
Max Metz
2024-07-31 09:58:15 +0200
19b4f34feefound the bremen_calling_logo.png file within the client's resources. Mapping towards that file when creating email notifications. This alleviates an additional dependency.
Max Metz
2024-07-31 09:04:35 +0200
40393fd476adding the Notifier to schedule routines with an execution routine of 15 minutes. Notifications must be at least 10 minutes old and still relevant to be sent.
Max Metz
2024-07-31 08:35:40 +0200
3d1391ed45included the Notifier in the routine. Will be executed every 15 minutes for notifications, which are at least 10 minutes old.
Max Metz
2024-07-31 08:28:44 +0200
1bdfa8997fclearing older methods of the Notifier class. There is now a one-line function, which connects to the Email-server, populates candidates for notifications, creates those notifications one-by-one and sends them. Finally, the database is updated, so a notification is sent only once.
Max Metz
2024-07-30 17:43:17 +0200
9cef84a5a8creating an HTML Email template for notifications, which includes a logo file (#TODO: store logo within BreCal git). Built out most of the Notifier. Provided suitable SQLQueries and updated the EmailHandler.
Max Metz
2024-07-30 17:20:51 +0200
cea615fe63building out and preparing the EmailHandler's adaptive content. Using HTML formatting.
Max Metz
2024-07-30 11:41:46 +0200
b5eb394978local db file adaptation
Max Metz
2024-07-30 08:35:14 +0200
cd8c246d72adapting times POST, PUT, DELETE to properly include the special case, where a BSMD user should also be allowed to handle times entries of an AGENCY, if the agency has the flag set.
Max Metz
2024-06-10 14:45:36 +0200
83520a2bc7Fixed small issues for ships endpoint validationDaniel Schick2024-07-09 09:04:05 +0200
3d2e1f5158Added input validation for API requests. Refactored some methods, added docstrings. Solved marshmallow-warnings in BreCal.schemas.model. Added unit tests, now totaling 215. Added proposals to refactor all SQL queries into an object at BreCal.database.sql_queries.SQLQuery for better standardization. Created a helper-object to handle Emails, which prepares the notification-feature.
Max Metz
2024-06-10 07:27:58 +0200
e33833235dBugfix for comparer when times value is null and DateTime.Now is inconsistentDaniel Schick2024-07-25 09:38:10 +0200