Merge branch 'release/1.6.0' of ssh://lager/mnt/ext/git/git_brcal into release/1.6.0

misc/version.txt

@@ -1 +1 @@
-1.6.0.6
+1.6.0.8

src/BreCalClient/BreCalClient.csproj

@@ -8,8 +8,8 @@
     <SignAssembly>True</SignAssembly>
     <StartupObject>BreCalClient.App</StartupObject>
     <AssemblyOriginatorKeyFile>..\..\misc\brecal.snk</AssemblyOriginatorKeyFile>
-    <AssemblyVersion>1.6.0.6</AssemblyVersion>
+    <AssemblyVersion>1.6.0.8</AssemblyVersion>
-    <FileVersion>1.6.0.6</FileVersion>
+    <FileVersion>1.6.0.8</FileVersion>
     <Title>Bremen calling client</Title>
     <Description>A Windows WPF client for the Bremen calling API.</Description>
     <ApplicationIcon>containership.ico</ApplicationIcon>

src/BreCalClient/EditShipcallControl.xaml.cs

@@ -188,6 +188,8 @@ namespace BreCalClient
 
         void CheckForCompletion()
         {
+            if (this.ShipcallModel.Shipcall?.Canceled ?? false) return; // Cancelled shipcall never clicks ok
+
             bool isEnabled = true;
 
             isEnabled &= this.comboBoxShip.SelectedItem != null;
@@ -378,6 +380,8 @@ namespace BreCalClient
 
             bool editRightGrantedForBSMD = false;
 
+            if (this.ShipcallModel.Shipcall?.Canceled ?? false) return; // do not allow edit on canceled shipcall
+
             // Special case: Selected Agency allows BSMD to edit their fields
             if (this.comboBoxAgency.SelectedIndex >= 0)
             {

src/BreCalClient/EditTimesAgencyIncomingControl.xaml.cs

@@ -366,7 +366,7 @@ namespace BreCalClient
 
         private void CheckOKButton()
         {
-            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet();
+            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet() && !(this.ShipcallModel.Shipcall?.Canceled ?? false);
         }
 
         #endregion

src/BreCalClient/EditTimesAgencyOutgoingControl.xaml.cs

@@ -356,7 +356,7 @@ namespace BreCalClient
 
         private void CheckOKButton()
         {
-            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet();
+            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet() && !(this.ShipcallModel.Shipcall?.Canceled ?? false);
         }
 
         #endregion

src/BreCalClient/EditTimesAgencyShiftingControl.xaml.cs

@@ -394,7 +394,7 @@ namespace BreCalClient
 
         private void CheckOKButton()
         {
-            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet();
+            this.buttonOK.IsEnabled = _editing && RequiredFieldsSet() && !(this.ShipcallModel.Shipcall?.Canceled ?? false);
         }
 
         #endregion

src/BreCalClient/EditTimesControl.xaml.cs

@@ -259,7 +259,7 @@ namespace BreCalClient
 
             // setting en/dis-abled
 
-            if (this.Times.ParticipantId != App.Participant.Id)
+            if ((this.Times.ParticipantId != App.Participant.Id) || (this.ShipcallModel.Shipcall?.Canceled ?? false))
             {
                 this.buttonFixedOrder.IsEnabled = false;
                 this.buttonOK.IsEnabled = false;

src/BreCalClient/EditTimesTerminalControl.xaml.cs

@@ -217,7 +217,7 @@ namespace BreCalClient
 
         private void EnableControls()
         {
-            if (this.Times.ParticipantId != App.Participant.Id)
+            if ((this.Times.ParticipantId != App.Participant.Id) || (this.ShipcallModel.Shipcall?.Canceled ?? false))
             {
                 this.buttonOK.IsEnabled = false;
                 return;

src/BreCalClient/Properties/PublishProfiles/ClickOnceTestProfile.pubxml

@@ -5,7 +5,7 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
 <Project>
   <PropertyGroup>
     <ApplicationRevision>6</ApplicationRevision>
-    <ApplicationVersion>1.6.0.6</ApplicationVersion>
+    <ApplicationVersion>1.6.0.8</ApplicationVersion>
     <BootstrapperEnabled>True</BootstrapperEnabled>
     <Configuration>Debug</Configuration>
     <CreateDesktopShortcut>True</CreateDesktopShortcut>
@@ -41,7 +41,7 @@ https://go.microsoft.com/fwlink/?LinkID=208121.
     <PublishDir>bin\Debug\net6.0-windows\win-x64\app.publish\</PublishDir>
     <RuntimeIdentifier>win-x64</RuntimeIdentifier>
     <SkipPublishVerification>false</SkipPublishVerification>
-    <MinimumRequiredVersion>1.6.0.6</MinimumRequiredVersion>
+    <MinimumRequiredVersion>1.6.0.8</MinimumRequiredVersion>
   </PropertyGroup>
   <ItemGroup>
     <PublishFile Include="containership.ico">

src/server/BreCal/validators/input_validation_shipcall.py

@@ -498,7 +498,7 @@ class InputValidationShipcall():
 
         # if the *existing* shipcall in the database is canceled, it may not be changed
         if shipcall.get("canceled", False):
-            raise ValidationError({"canceled":f"The shipcall with id 'shipcall_id' is canceled. A canceled shipcall may not be changed."})
+            raise ValidationError({"canceled":f"The shipcall with id {shipcall_id} is canceled. A canceled shipcall may not be changed."})
         return
 
     @staticmethod