Commit Graph

616 Commits

Author SHA1 Message Date
e60a623753 Do port dependencies for comboboxes also when loading existing shipcall 2024-12-04 10:28:47 +01:00
ddae95b784 Make pier filter combobox dependent on selected harbour 2024-12-04 10:28:34 +01:00
184d15554b Port may only be changed if the shipcall is created 2024-12-04 10:28:24 +01:00
0d9e4ac026 fixed some missing client warnings 2024-11-19 12:26:33 +01:00
25013b4edc fixed comparison typo 2024-11-14 11:48:12 +01:00
3775d6775c adding missing defaults when shipcall is not yet created 2024-11-14 11:47:57 +01:00
9bb847242c Fixed situation where end time was reset after from time left 24h window 2024-11-14 11:47:34 +01:00
2576127b79 serverside fixes for detecting unchanged time values 2024-11-14 11:45:24 +01:00
08792c5fa7 Apply 1 day past rule to both from and to times on eta / etd to avoid loophole 2024-11-14 11:44:27 +01:00
effbf42303 If the agency provided a time, display it in the BSMD column. Also corrected ETD/ETA Label right there 2024-11-08 09:59:37 +01:00
b070979723 Allow new shipcalls up to 1 day in the past for serverside validation 2024-11-08 09:41:04 +01:00
d6e3ae20c1 Allow new shipcalls up to 1 day in the past for serverside validation 2024-11-08 09:37:46 +01:00
b5a8a3d31c added -1 day time logic to client 2024-11-08 09:35:07 +01:00
be5859424d allow ATA changes in the past, allow OK click if time values have not been changed 2024-11-08 09:33:34 +01:00
72d3ad05bf Added validation rules regarding port_id (for berth and participant assignment) 2024-10-23 09:55:56 +02:00
0d7861ec36 If a PUT or DELETE operation is attempted on a non-existant object, 404 is returned 2024-10-21 10:37:35 +02:00
4531eda8f1 more validation input fixes 2024-10-19 19:59:38 +02:00
b5b78a9c7e Fixed tidal window validation and description output 2024-10-19 19:59:17 +02:00
f0720b9b1d Fixed some more small bugs in validation when only a partial times dataset is put 2024-10-19 19:58:46 +02:00
bac3421a64 Fix text filter if there is whitespace in the text, simplified some events 2024-10-19 19:57:07 +02:00
11098da25b bugfix for shipcall PUT validation 2024-10-19 19:56:29 +02:00
scopesorting
fb8b732b1d regardless of the BSMD flag, BSMD users are now able to perform shipc… (#51)
* regardless of the BSMD flag, BSMD users are now able to perform shipcall PUT-requests

* regardless of the BSMD flag, BSMD users are now able to perform shipcall PUT-requests

* docstrings and BSMD-flag handling
2024-10-19 19:56:08 +02:00
4a0943c64f Version bump to 1.6.0.4 2024-10-19 19:51:32 +02:00
2a47dd6534 Avoid harbour selection changed event when initializing dialog 2024-10-19 19:39:03 +02:00
dd5d334e96 Version bump to 1.6.0.3 2024-10-01 08:37:34 +02:00
34c91497f3 Only allow harbours to be selected where the current user is assigned to 2024-10-01 08:36:30 +02:00
e18188cd85 don't allow a changed port when creating departure after a new arrival 2024-10-01 08:19:11 +02:00
4b1f773c6f changed last change highlight colors 2024-09-30 08:36:45 +02:00
1d64a83d32 Fixed error in validation when times data was updated for operations 2024-09-30 08:32:18 +02:00
0eaea46409 Limit shifting number to 127 to avoid int -> uint overflow on insert 2024-09-30 08:31:50 +02:00
f3c5111265 Upgrade to python 3.12 on the server, exported current requirements 2024-09-23 08:09:59 +02:00
d7919922fc Version bump to 1.6.0.2 and making 1.6.0.2 the minimum win client version 2024-09-20 14:10:14 +02:00
90d32a26f1 Show last change date permanently in the header. Latest value is highlighted 2024-09-20 12:24:59 +02:00
ed6f5ab648 essential bugfixes 2024-09-20 09:46:48 +02:00
12c1fc59b1 Merge branch 'feature/client_with_ports' into develop 2024-09-19 09:45:38 +02:00
a06ec0eabb Bump version to 1.6.0.1 2024-09-19 09:26:46 +02:00
de94d63a41 Make nomination comboboxes dependant on selected harbour 2024-09-19 09:25:24 +02:00
3b3601baeb Added agency port dependency when editing shipcalls 2024-09-19 09:10:15 +02:00
Max Metz
7abf0e26e2 when a ship is deleted, the IMO is no longer considered to exist 2024-09-18 08:34:21 +02:00
Max Metz
cc29320c87 BSMD-flag check was executed on the wrong ID. Now, it correctly uses the assigned agency's ID to determine the presence of a BSMD flag 2024-09-18 08:33:59 +02:00
402c9807c9 Merge branch 'bugfix/extend_clientside_validation' into develop 2024-09-17 09:45:54 +02:00
8c23df8cda Added extra too far in the future validation on the client-side 2024-09-17 09:40:36 +02:00
470110ef5b Ensure both or none of the tidal window times are set when leaving the agency dialogs 2024-09-17 08:47:43 +02:00
081995990f Only allow editing (OK-Button enabled) for the assigned owner of the times record 2024-09-17 08:26:39 +02:00
d2bab6e2c2 only allow saving if ETA time is greater than ETD time when shifting 2024-09-17 08:04:26 +02:00
6215449bc8 Filter berths in combobox by selected port. Might still need some work.. 2024-09-16 16:38:55 +02:00
80ad3e8e5a Show port in shipcall control overview at the bottom left 2024-09-16 16:02:57 +02:00
948684455d Add port selection to shipcall create / edit dialog 2024-09-16 15:31:12 +02:00
0e7493366c Added port filter to main screen and allowed port filtering 2024-09-16 14:18:57 +02:00
5ce866936d unified return structure to use error_field instead of message key to correspond to API specification 2024-09-16 14:17:30 +02:00
a68a768277 fixed bug in ports GET 2024-09-15 16:13:47 +02:00
489dfc2ed6 added port_id and ports endpoint to flask app (no validation yet!), reading works 2024-09-13 17:45:31 +02:00
c796be2892 Upgraded client library references due to security warnings 2024-09-12 16:44:15 +02:00
6a6ffa38f9 extended OpenAPI with port endpoint and refs, adjusted some code to compile 2024-09-12 16:43:39 +02:00
cc17e6c33a Merge branch 'feature/1.6_database_changes' into develop 2024-09-12 11:48:56 +02:00
5625cbac49 reverted settings for test version 2024-09-12 11:31:16 +02:00
Max Metz
aaea8441f6 shifting the ship-id check into the validation object 2024-09-12 10:22:27 +02:00
Max Metz
82ad56812e correcting an issue in the DELETE methods for SHIPS and TIMES, where the ID may have been provided as a null value or was incorrectly converted (string instead of integer) 2024-09-12 10:19:26 +02:00
82969c8726 Merge branch 'bugfix/validation_feedback' into release/1.5.0 2024-09-12 09:43:45 +02:00
4e39510be6 Version bump to 1.5.0.4 2024-09-11 09:11:46 +02:00
e7a6aa6584 fixed some cut and paste error and a crash when changing the assignment fails by API 2024-09-11 08:41:49 +02:00
282a860c42 Version bump to 1.5.0.2 2024-09-11 07:08:14 +02:00
a0d27289ae removed unnecessary float conversion 2024-09-10 21:46:30 +02:00
a497f7f2a0 fixed typo in error message 2024-09-10 21:15:52 +02:00
a305ee3bed Version bump to 1.5.0.2 2024-09-10 21:14:21 +02:00
38563d5b38 Simplified error display dialog 2024-09-10 18:06:28 +02:00
Max Metz
7c5bc626d0 improving documentation 2024-09-10 17:47:44 +02:00
Max Metz
6505ad758f bsmd authorization for times PUT 2024-09-10 17:45:32 +02:00
Max Metz
5b68ef95cb adapting exception handling and error responses for 400 responses. Using a simplified format, which only uses the keys 'error_field' and 'error_description' 2024-09-10 17:37:08 +02:00
Max Metz
590df30fef A ship's IMO-validation was used in POST and PUT requests. This caused an issue for POST requests. 2024-09-10 14:48:20 +02:00
Max Metz
c90b002806 Times POST no longer raises a ValidationError when the provided time is in the past. 2024-09-10 14:17:03 +02:00
Max Metz
7a97cd7d95 format of exceptions now always follows baseline format. 'errors'-key is always a list of dictionaries. 2024-09-10 13:50:13 +02:00
67c852482e Added some warnings if time intervals or particular values lie in the past for shipcall and agency 2024-09-09 18:27:03 +02:00
Max Metz
9127cdeac8 BSMD users are now allowed to POST times entry, if they are assigned to the ShipcallParticipantMap or the special BSMD-flag-clause takes place 2024-09-09 17:06:03 +02:00
93362d3695 Don't crash on ship delete API error 2024-09-09 13:11:56 +02:00
Max Metz
d2cd233f13 creating default handlers for every kind of Exception in the /api/ routes. Those default functions also create automatic logging with the .warning level. Relocated the .impl-calls into the Try-Exception-blocks, so they are properly logged and avoid system failures. 2024-09-09 12:46:55 +02:00
Max Metz
85973ad848 creating a default error response format for each API route 2024-09-09 12:21:32 +02:00
Max Metz
61b00b8b22 auto-converting non-lists to list values. 2024-09-09 11:55:58 +02:00
Max Metz
ab7b1ed34f every ValidationError is defined to return a dictionary. In case of validation errors without such a call, a function enforces a default with an undefined key to ensure the correct format. 2024-09-05 12:46:04 +02:00
1243ebf9e7 Adjusted error formatting and bumped test version to 1.5.0.1 2024-09-05 06:49:25 +02:00
Max Metz
c7371a945a adapting traffic light validation 0002-C. This no longer requires ETA verification. Adapted the description when the error occurs and renamed the function. 2024-09-04 12:21:22 +02:00
Max Metz
e4d0ea2301 fixed serialization of marshmallow.ValidationErrors. This was caused by the 'valid_data' containing datetime objects, which were not serializable natively. 2024-09-04 12:11:32 +02:00
Max Metz
2f678267c8 time estimations are no longer dependency on times POST requests. This refers to eta_berth, etd_berth, operations_start, operations_end. 2024-09-04 11:41:03 +02:00
Max Metz
2c0a73113b shipcall PUTs may no longer change the shipcall type 2024-09-04 11:17:32 +02:00
Max Metz
3d2405e8fb maintenance of API Input Validation (ship & times) 2024-09-04 10:27:46 +02:00
Max Metz
1ff972883f adding input validation for time intervals 2024-09-04 10:27:38 +02:00
76995a84e4 Added the port reference to management of berths incl. excel import 2024-09-04 09:50:53 +02:00
Max Metz
4b5ff90b34 properly serializing ValidationError exceptions. 2024-09-04 08:30:46 +02:00
6cfd311bbb Version bump to 1.6 2024-09-04 08:09:13 +02:00
8b4c9e2590 Extending the role editor pt.2 2024-09-04 08:09:00 +02:00
de7a9a05f2 Extending the role editor pt. 1 2024-09-03 10:03:36 +02:00
983c21ba67 don't crash on badly formatted error messages 2024-09-02 08:48:40 +02:00
ed7c4fbfbb Created test version including version bump to 1.5.0 2024-08-30 11:27:10 +02:00
1f854b6cde Merge branch 'feature/improve_error_display' into develop 2024-08-29 09:21:52 +02:00
78ab83628b Version bump to 1.4.1 (due to API change) 2024-08-29 09:01:21 +02:00
Max Metz
2ac2bc196c potentially resolving the 'Unknown column ... in 'field list' issue 2024-08-28 18:44:45 +02:00
b154f73ce9 Convenience: If creating a new ship fails, the ship is shown again when the dialog is re-opened 2024-08-28 17:35:58 +02:00
65779731fd Show the content of the message info from the failure exception 2024-08-28 17:04:04 +02:00
Max Metz
a51b830cf6 removed the 'canceled may not be set on post'-issue. 2024-08-28 13:06:36 +02:00
Max Metz
1be7d68f5c participant flag also resolved 2024-08-27 21:16:49 +02:00
Max Metz
cc2a54c1c6 added extensive logging for an open, unresolved issue. The issue-log may make clear, where the issue originates 2024-08-27 21:14:30 +02:00
Max Metz
e1d9570268 solving the concatenation issue of a list and a None-type. 2024-08-27 20:52:10 +02:00
Max Metz
8082100b7e using the @classmethod _missing_ function in an IntFlag creates an incorrect resolution of intflags. 127 was resolved as 0 due to the _missing_ function. Without that method, 127 becomes a proper multi-flag 2024-08-27 20:33:33 +02:00
Max Metz
6eab98d2a1 correcting the issue with participant_id authorization (BSMD or AGENCY check). 2024-08-27 19:23:37 +02:00
Max Metz
fcc03b2ade adaptation of traffic validation (resolving open issue) 2024-08-14 19:09:35 +02:00
Max Metz
c4e5764601 /ships GET no longer blocks deleted ships from being returned. 2024-08-14 15:53:37 +02:00
Max Metz
b60874cbb0 shipcall, ship, times and user verify the validity of JSON data when receiving POST/PUT requests. 2024-08-14 15:49:28 +02:00
Max Metz
e488501837 debugging the missing column '.PORT_ADMINISTRATION' issue 2024-08-14 14:58:03 +02:00
Max Metz
4f3686e00f marshmallow.fields incorrectly resolved the 'required' field. Adapted each field to ensure that missing data properly raises an error. 2024-08-14 13:59:26 +02:00
Max Metz
0e8faf499d GET ships no longer returns deleted ships 2024-08-12 20:35:37 +02:00
Max Metz
22009eb469 resolving an issue where missing values for 'flags' in the Shipcall would cause rule-violations 2024-08-12 19:56:26 +02:00
Max Metz
e526337c6a added a reference check to PUT-requests (shipcall), so each provided ID must exist. Corrected some input validation functions to solve known bugs 2024-08-12 19:43:19 +02:00
Max Metz
d54fed9160 corrected open issues of the API validation functions. Made some validation errors more verbose, improved robustness, refactored some of the methods and adapted many unit tests to the novel format. 2024-08-06 20:46:40 +02:00
Max Metz
3ce2fc829d correcting a validation issue for 'voyage' 2024-08-01 18:34:56 +02:00
Max Metz
5769889fea resolving the validation issue in shipcalls, which was caused by a faulty fields type in the ShipcallSchema. 2024-07-31 14:59:59 +02:00
Max Metz
cd8c246d72 adapting times POST, PUT, DELETE to properly include the special case, where a BSMD user should also be allowed to handle times entries of an AGENCY, if the agency has the flag set. 2024-07-25 10:42:44 +02:00
83520a2bc7 Fixed small issues for ships endpoint validation 2024-07-25 10:42:44 +02:00
Max Metz
3d2e1f5158 Added input validation for API requests. Refactored some methods, added docstrings. Solved marshmallow-warnings in BreCal.schemas.model. Added unit tests, now totaling 215. Added proposals to refactor all SQL queries into an object at BreCal.database.sql_queries.SQLQuery for better standardization. Created a helper-object to handle Emails, which prepares the notification-feature. 2024-07-25 10:42:44 +02:00
e33833235d Bugfix for comparer when times value is null and DateTime.Now is inconsistent 2024-07-25 10:41:22 +02:00
d7de35236c Version bump to 1.4 2024-07-22 10:40:08 +02:00
14569ad7bc Reset values button on times and times terminal dialog boxes to completely undo entries.
Also fixed bug where clear context menu was disabled and wouldn't disappear
2024-07-22 08:51:20 +02:00
9bf84f8baa remove required fields for Times and Times Terminal 2024-07-22 08:22:09 +02:00
31c54f9d8f ETD is always enabled if user is bsmd group (was typo? can't recall) 2024-07-22 07:06:41 +02:00
ad16ae4945 Bugfix: ATA/ATD values do not get changed when already displayed 2024-07-18 07:22:25 +02:00
1a5591cc39 even more small fixes 2024-07-14 15:12:49 +02:00
e30309bca2 fixed more small things and version bump to 1.3.0.3 2024-07-13 19:18:41 +02:00
64977d5819 Small-time fixes to things previously changed and version bump to 1.3.0.2 2024-07-12 16:29:32 +02:00
9d017524ef Added shifting sequence number, storage hidden in flags. This is a prototype. 2024-07-12 09:32:09 +02:00
24138fc1e9 Fixed an error regarding berth display in AGENT/TERMINAL and set to+from berth info for shifting shipcalls 2024-07-11 11:39:12 +02:00
ec0eb3cbfa Switched visibility and position of ETA/ETD in shipcall dialog depending on type 2024-07-11 08:08:33 +02:00
e03c8dc7df User-Filter Settings now on a per-user basis, saved as a dictionary in user space.
This is for the case of people using the same windows account but with several different BC users.
2024-07-10 10:35:40 +02:00
ac8b6ba491 Hide some controls depending on arrival/departure 2024-07-10 09:28:36 +02:00
e3000e1f16 Removed ETA from times dialog if shifting shipcall 2024-07-10 09:05:45 +02:00
208d74f9e3 When creating a new shipcall 'Geeste' is the default time ref point 2024-07-09 11:54:15 +02:00
39020fc5d3 Bugfix: Changed lock times not showing immediately 2024-07-09 10:01:36 +02:00
8f40b82c5d Ship list WIP 2024-07-09 08:10:01 +02:00
c8c60c0f9b Only user Interval end if interval start is also unset (as suggestion in terminal control) 2024-07-01 13:25:54 +02:00
6f1346c430 Fixed 4 digit time entry 2024-07-01 13:25:16 +02:00
ac21a2fa45 Changed interval date formatting so intervals spanning multiple days show ok 2024-07-01 13:24:05 +02:00
fe46b9b94e Filter shipcalls that have ata set and ata is more than 2 hours in the past 2024-07-01 13:22:29 +02:00
b275320d54 For the interval, the end date is also set in the control 2024-07-01 13:22:17 +02:00
570a227b78 Simplified input text filtering:
If user enters 10 digits, then these are split up for the date
2024-07-01 13:22:04 +02:00
bb956d4792 include last minute for day filter 2024-07-01 13:21:49 +02:00
71a8b44532 fixed bug in search filter where time component wasnt cut of (as expected) 2024-07-01 13:21:28 +02:00
36e853fcda Enter Agency Time as highlighted suggestion for other participants (not terminal) 2024-07-01 13:21:09 +02:00
bc6a9e95ea Removed compiler message 2024-06-24 15:27:09 +02:00
a5753727a7 Added button for automatically selecting the next 24 hours, meaning filling the ETA from/to fields
automatically and triggering the search
2024-06-24 15:21:37 +02:00
69b9e8bcfe Added derived DateTimePicker to use custom keyboard parsing (numbers only) 2024-06-24 14:37:10 +02:00
090fa6cfda Removed some hardcoded text and renamed Lotsen to Flusslotsen 2024-06-24 07:23:34 +02:00
eb62097278 Improved Text input for datetime picker Control 2024-06-23 15:31:55 +02:00