Max Metz
|
e526337c6a
|
added a reference check to PUT-requests (shipcall), so each provided ID must exist. Corrected some input validation functions to solve known bugs
|
2024-08-12 19:43:19 +02:00 |
|
Max Metz
|
3d2e1f5158
|
Added input validation for API requests. Refactored some methods, added docstrings. Solved marshmallow-warnings in BreCal.schemas.model. Added unit tests, now totaling 215. Added proposals to refactor all SQL queries into an object at BreCal.database.sql_queries.SQLQuery for better standardization. Created a helper-object to handle Emails, which prepares the notification-feature.
|
2024-07-25 10:42:44 +02:00 |
|
scopesorting
|
ad7637368b
|
removing unused if-statements
|
2023-12-15 16:40:51 +01:00 |
|
scopesorting
|
08ab984096
|
updating the sql handler's method of filtering for the filled-in header
|
2023-12-15 16:40:51 +01:00 |
|
scopesorting
|
fce8ce0c68
|
changing the ParticipantType to an IntFlag, so multiple roles are possible. Adapting every validation rule (0001, 0003, 0004, 0005), which may be affected by this change. Changing the filter for a participant type to properly include the change. Changing the pier_side rule (0006B), which uses the shipcall and times_terminal. New shipcalls should now be evaluated properly, unless no participant is assigned at all. If the ladder case can occur, the validation rules 0001N+0001O will be added (held back for now).
|
2023-12-01 09:44:09 +02:00 |
|
scopesorting
|
6f9b4a6b5a
|
removing verbosity in validation rule functions, and returning 'None', when a selected times dataframe is empty. In case of empty results, the function now properly computes the delta towards a query time and returns YELLOW, when a violation is observed. This should finally fix the bugs for 0001 A-M
|
2023-12-01 09:43:49 +02:00 |
|
scopesorting
|
9a12d74e77
|
updating validation rules 0001 A-M. Instead of filtering by times_df (which may not exist), the rules make use of the shipcall_participant_map. When one of the participants in a rule is not assigned, no violation is observed. When there are multiple entries of a participant (due to an input bug), the function still verifies properly. When critical time is observed, and there is not yet an entry for the respective key time, there will be a 'yellow' state.
|
2023-12-01 09:43:31 +02:00 |
|
scopesorting
|
8027620f22
|
fixing the 'KeyError' when using an empty times dataframe. Returning 'green'
|
2023-11-28 16:48:53 +02:00 |
|
|
|
c36e913472
|
added trace output and fixed a bug when saving shipcalls without times
|
2023-11-28 16:48:16 +02:00 |
|
scopesorting
|
9346920a97
|
potentially solving the 'shipcall_id' error log
|
2023-11-21 11:51:49 +01:00 |
|
scopesorting
|
3cc1591aba
|
potentially correcting 0006A/0006B
|
2023-11-21 11:41:56 +01:00 |
|
scopesorting
|
40dc022b25
|
fixing np to_list error, which may have caused the evaluation function to stop altogether.
|
2023-11-20 16:22:58 +01:00 |
|
scopesorting
|
e9aace6268
|
creating stub objects for every single validation function. Unit tests are created for each function to check whether they return 'GREEN' whenever no violation is expected, or 'YELLOW'/'RED' when a rule violation is artificially forced. The test framework now successfully runs 116 unit tests. Adapted some validation functions, applied refactoring and solved potential obstacles along the way. At least from the perspective of unit tests, every function now works as expected.
|
2023-11-10 17:59:08 +01:00 |
|
scopesorting
|
2374cf4ff0
|
Feature/removing pandas warning (#14)
* removing the Pandas 'sqlalchemy' warning by refactoring
* removing the Pandas 'sqlalchemy' warning by refactoring.
* reformatting
|
2023-11-07 07:08:52 +01:00 |
|
scopesorting
|
cdb7877461
|
Adding validation rules (traffic light status) to the system. Post & Put calls of shipcalls and times now execute the traffic light evaluation and store the result in the connected MySQL database instance. The 'brecal_utils' library is merged with 'BreCal', including the stub objects and test functions. Requirements were adapted, and installation of a virtual environment works from scratch (on a linux system).
|
2023-10-19 18:32:49 +02:00 |
|