bsmd.database/MessageTelemetry.cs

@@ -34,64 +34,37 @@ namespace bsmd.database
 
         public static void Enqueue(Message.NSWProvider provider, Message message)
         {
-            // Validate inputs
-            if (message == null)
-            {
-                _log.ErrorFormat("Enqueue called with null message for provider {0}", provider);
-                return;
-            }
-
-            if (!message.Id.HasValue)
-            {
-                _log.ErrorFormat("Enqueue called with message that has no Id assigned for provider {0}", provider);
-                return;
-            }
-
             if (!_telemetry.ContainsKey(provider))
                 _telemetry.Add(provider, new Dictionary<Guid, MessageTelemetry>());
 
-            Guid messageId = message.Id.Value;
+            if (_telemetry[provider].ContainsKey(message.Id.Value))
-
-            if (_telemetry[provider].ContainsKey(messageId))
             {
-                _telemetry[provider][messageId].NumTries++;
+                _telemetry[provider][message.Id.Value].NumTries++;
             }
             else
             {
                 MessageTelemetry mt = new MessageTelemetry();
                 mt.SendDate = DateTime.Now;
                 mt.NumTries = 1;
-                _telemetry[provider][messageId] = mt;
+                _telemetry[provider][message.Id.Value]  = mt;
             }
         }
 
         public static void Dequeue(Message.NSWProvider provider, Message message)
         {
-            if (message == null)
-            {
-                _log.ErrorFormat("Dequeue called with null message for provider {0}", provider);
-                return;
-            }
-
-            if (!message.Id.HasValue)
-            {
-                _log.ErrorFormat("Dequeue called with message that has no Id assigned for provider {0}", provider);
-                return;
-            }
-
             if (_telemetry.ContainsKey(provider))
             {
-                Guid messageId = message.Id.Value;
+                if (_telemetry[provider].ContainsKey(message.Id.Value))
-                if (_telemetry[provider].ContainsKey(messageId))
                 {
-                    MessageTelemetry mt = _telemetry[provider][messageId];
+                    MessageTelemetry mt = _telemetry[provider][message.Id.Value];
-                    _log.InfoFormat("[{0,10}][{1,8}][{2:00000}][{3:00}] ", provider, message.MessageNotificationClassDisplay, (DateTime.Now - mt.SendDate).TotalSeconds, mt.NumTries);
+                    _log.InfoFormat("[{0,10}][{1,8}][{2:00000}][{3:00}] ",provider, message.MessageNotificationClassDisplay, (DateTime.Now - mt.SendDate).TotalSeconds, mt.NumTries);
-                    _telemetry[provider].Remove(messageId);
+                    _telemetry[provider].Remove(message.Id.Value);
                 }
                 else
                 {
+                    // this can happen if the service gets re-started and not all sent messages have yet been received
                     _log.WarnFormat("trying to deque a message from telemetry that we don't know about. Provider: {0} MessageId: {1}",
-                        provider.ToString(), messageId);
+                        provider.ToString(), message.Id.Value);
                 }
             }
         }

bsmd.hisnord/Request.cs

@@ -85,18 +85,6 @@ namespace bsmd.hisnord
             bool? retval;
             try
             {
-                if (core == null)
-                {
-                    _log.ErrorFormat("CreateSendFile called with null core");
-                    return false;
-                }
-
-                if (!core.Id.HasValue)
-                {
-                    _log.ErrorFormat("CreateSendFile called with core that has no Id assigned");
-                    return false;
-                }
-
                 nsw _nsw = new nsw();
                 _nsw.conveyance = new conveyance();
 
@@ -133,9 +121,8 @@ namespace bsmd.hisnord
                 _nsw.conveyance.owner_sender.contact.phone = rp.Phone;
                 _nsw.conveyance.owner_sender.contact.fax = rp.Fax;
 
-                Guid coreId = core.Id.Value;
+                _nsw.document_reference = core.Id.Value.ToString();
-                _nsw.document_reference = coreId.ToString();
+                _nsw.conveyance.code = core.Id.ToString();
-                _nsw.conveyance.code = coreId.ToString();
 
                 if (!core.VisitId.IsNullOrEmpty())
                 {