ENI2/Controls/MaerskListControl.xaml.cs

@@ -338,8 +338,7 @@ namespace ENI2.Controls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row

ENI2/DetailRootControl.xaml.cs

@@ -17,7 +17,6 @@ using ENI2.EditControls;
 using System.Windows.Input;
 using System.Linq;
 using ENI2.SheetDisplayControls;
-using System.Threading.Tasks;
 
 namespace ENI2
 {
@@ -35,9 +34,6 @@ namespace ENI2
         // private readonly Dictionary<Message.NotificationClass, string> messageClassControlDict = new Dictionary<Message.NotificationClass, string>();
         private readonly object messageListLock = new object();
         private readonly HighlightService highlightService = new HighlightService();
-        private readonly object validationLock = new object();
-        private Task<ValidationResult> activeValidationTask = null;
-        private bool pendingShowMessages = false;
 
         // Referenzen für Fehler/Violation Dialoge (können, müssen aber nicht offen bleiben)
         protected ErrorListDialog _errorListDialog = null;
@@ -707,13 +703,7 @@ namespace ENI2
 
         private void DetailControl_RequestSendValidation()
         {
-            DetailControl_RequestSendValidationAsync();
-        }
-
-        private async void DetailControl_RequestSendValidationAsync()
-        {
-            ValidationResult result = await ValidateAndApplyAsync(false);
-            List<MessageError> errorList = result.Errors;
+            this.Validate(false, out _, out List<MessageError> errorList);
 
             foreach (Message aMessage in this._messages)
             {
@@ -787,60 +777,22 @@ namespace ENI2
             }
         }
 
-        private async void DetailControl_RequestValidate(bool showDialog)
+        private void DetailControl_RequestValidate(bool showDialog)
         {
-            await ValidateAndApplyAsync(showDialog);
+            this.Validate(showDialog, out _, out _);
         }
 
-        private async Task<ValidationResult> ValidateAndApplyAsync(bool showMessages)
+        private void Validate(bool showMessages, out List<MessageViolation> vViolations, out List<MessageError> vErrors)
         {
-            Task<ValidationResult> validationTask = null;
-            lock (validationLock)
-            {
-                if (activeValidationTask != null && !activeValidationTask.IsCompleted)
-                {
-                    if (showMessages)
-                        pendingShowMessages = true;
-                    validationTask = activeValidationTask;
-                }
-                else
-                {
-                    pendingShowMessages = showMessages;
-                    activeValidationTask = ValidateAndApplyCoreAsync();
-                    validationTask = activeValidationTask;
-                }
-            }
+            vViolations = new List<MessageViolation>();
+            vErrors = new List<MessageError>();
 
-            return await validationTask;
-        }
+            // TODO: clear highlighting
 
-        private async Task<ValidationResult> ValidateAndApplyCoreAsync()
-        {
             Util.UIHelper.SetBusyState();
-            ApplyCrewEffectsWarningSuppression();
-
-            List<Message> messagesSnapshot = _messages.ToList();
-            ValidationResult result = await Task.Run(() => ValidateCore(messagesSnapshot));
-
-            bool showMessages;
-            lock (validationLock)
-            {
-                showMessages = pendingShowMessages;
-                pendingShowMessages = false;
-                activeValidationTask = null;
-            }
-
-            ApplyValidationResult(result, showMessages);
-            return result;
-        }
-
-        private ValidationResult ValidateCore(List<Message> messagesSnapshot)
-        {
-            List<MessageViolation> vViolations = new List<MessageViolation>();
-            List<MessageError> vErrors = new List<MessageError>();            
 
             RuleEngine ruleEngine = new RuleEngine();
-            foreach (Message aMessage in messagesSnapshot)
+            foreach (Message aMessage in _messages)
             {
                 if (!aMessage.EvaluateForValidation(this.Core.IsTransit)) continue;
 
@@ -848,6 +800,21 @@ namespace ENI2
                 List<MessageViolation> violations = new List<MessageViolation>();
                 ruleEngine.ValidateMessage(aMessage, out errors, out violations);
 
+                if (errors.Count > 0)
+                    aMessage.ErrorCount = errors.Count;
+                else
+                    aMessage.ErrorCount = null;
+                if (violations.Count > 0)
+                {
+                    aMessage.ViolationCount = violations.Count;
+                    aMessage.PositionViolationCount = violations.Count(v => !v.Identifier.IsNullOrEmpty());
+                }
+                else
+                {
+                    aMessage.ViolationCount = null;
+                    aMessage.PositionViolationCount = null;
+                }
+
                 string messageGroup = this.MessageGroupForMessage(aMessage);
 
                 if (messageGroup != null)
@@ -862,22 +829,22 @@ namespace ENI2
                 vViolations.AddRange(violations);
             }
 
-            #region 12.11.18 / 6.3.21 / 23.5.22 / 26.10.24 / 27.1.26: globale Plausi-Prüfungen
+            #region 12.11.18 / 6.3.21 / 23.5.22 / 26.10.24: globale Plausi-Prüfungen
 
-            Message crewaMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWA);
-            Message crewdMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWD);
-            Message pasaMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.PASA);
-            Message pasdMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.PASD);
-            Message pobaMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.POBA);
-            Message pobdMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.POBD);
-            Message secMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.SEC);
-            Message noanodMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.NOA_NOD);
-            Message mdhMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.MDH);
-            Message was_rcptMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.WAS_RCPT);
-            Message wasMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.WAS);
-            Message servMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.SERV);
-            Message statMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.STAT);
-            Message pre72hMessage = messagesSnapshot.Find(message => message.MessageNotificationClass == Message.NotificationClass.PRE72H);
+            Message crewaMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWA);
+            Message crewdMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWD);
+            Message pasaMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.PASA);
+            Message pasdMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.PASD);
+            Message pobaMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.POBA);
+            Message pobdMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.POBD);
+            Message secMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.SEC);
+            Message noanodMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.NOA_NOD);
+            Message mdhMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.MDH);
+            Message was_rcptMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.WAS_RCPT);
+            Message wasMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.WAS);
+            Message servMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.SERV);
+            Message statMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.STAT);
+            Message pre72hMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.PRE72H);
 
             #region CREW / PAS Count Plausibility
 
@@ -1017,6 +984,22 @@ namespace ENI2
 
             #endregion
 
+            #region 4.1.23 no CREW effects warning for DE
+            if (crewaMessage != null)
+            {
+                MessageViolation mv = crewaMessage.ViolationList.Find((x) => x.PropertyName.Equals("Effects") && (x.ViolationCode == (int)ValidationCode.TRUNCATE));
+                if ((mv != null) && !Core.IsDK)
+                    crewaMessage.ViolationList.Remove(mv);
+            }
+
+            if(crewdMessage != null)
+            {
+                MessageViolation mvd = crewdMessage.ViolationList.Find((x) => x.PropertyName.Equals("Effects") && (x.ViolationCode == (int)ValidationCode.TRUNCATE));
+                if ((mvd != null) && !Core.IsDK)
+                    crewdMessage.ViolationList.Remove(mvd);
+            }
+            #endregion
+
             #region WAS_RCPT double numbers
 
             Dictionary<string, string> identDict = new Dictionary<string, string>();
@@ -1044,37 +1027,35 @@ namespace ENI2
 
             #region Kiel Canal Timing Plausibility
 
+            if (!this.Core.IsTransit && (secMessage?.Elements.Count > 0) && (noanodMessage?.Elements.Count > 0))
             {
-                if (!this.Core.IsTransit && (secMessage?.Elements.Count > 0) && (noanodMessage?.Elements.Count > 0))
+                SEC sec = secMessage.Elements[0] as SEC;
+                NOA_NOD noa_nod = noanodMessage.Elements[0] as NOA_NOD;
+
+                if (sec.KielCanalPassagePlanned ?? false)
                 {
-                    SEC sec = secMessage.Elements[0] as SEC;
-                    NOA_NOD noa_nod = noanodMessage.Elements[0] as NOA_NOD;
+                    // Überprüfung, ob die eingehende NOK-Durchfahrt auch wirklich innerhalb der eingehenden Reise liegt (bei VISIT)
+                    bool isValidIncoming = (noa_nod.ETDFromLastPort < sec.KielCanalPassagePlannedIncomming) &&
+                                            (sec.KielCanalPassagePlannedIncomming < noa_nod.ETAToPortOfCall);
+                    if (!sec.KielCanalPassagePlannedIncomming.HasValue) isValidIncoming = true;
 
-                    if (sec.KielCanalPassagePlanned ?? false)
+                    if(!isValidIncoming)
                     {
-                        // Überprüfung, ob die eingehende NOK-Durchfahrt auch wirklich innerhalb der eingehenden Reise liegt (bei VISIT)
-                        bool isValidIncoming = (noa_nod.ETDFromLastPort < sec.KielCanalPassagePlannedIncomming) &&
-                                                (sec.KielCanalPassagePlannedIncomming < noa_nod.ETAToPortOfCall);
-                        if (!sec.KielCanalPassagePlannedIncomming.HasValue) isValidIncoming = true;
-
-                        if (!isValidIncoming)
-                        {
-                            MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Kiel Canal incoming implausible (ETD / ETA ports)!", null, "Kiel Canal timing", null, "SEC");
-                            mv.MessageGroupName = Properties.Resources.textOverview;
-                            vViolations.Add(mv);
-                        }
+                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Kiel Canal incoming implausible (ETD / ETA ports)!", null, "Kiel Canal timing", null, "SEC");
+                        mv.MessageGroupName = Properties.Resources.textOverview;
+                        vViolations.Add(mv);
+                    }
 
 
-                        bool isValidOutgoing = (noa_nod.ETDFromPortOfCall < sec.KielCanalPassagePlannedOutgoing) &&
-                                ((noa_nod.NextPort == "ZZUKN") || (sec.KielCanalPassagePlannedOutgoing < noa_nod.ETAToNextPort));
-                        if (!sec.KielCanalPassagePlannedOutgoing.HasValue) isValidOutgoing = true;
+                    bool isValidOutgoing = (noa_nod.ETDFromPortOfCall < sec.KielCanalPassagePlannedOutgoing) &&
+                            ((noa_nod.NextPort == "ZZUKN") || (sec.KielCanalPassagePlannedOutgoing < noa_nod.ETAToNextPort));
+                    if (!sec.KielCanalPassagePlannedOutgoing.HasValue) isValidOutgoing = true;
 
-                        if (!isValidOutgoing)
-                        {
-                            MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Kiel Canal outgoing implausible (ETD / ETA ports)!", null, "Kiel Canal timing", null, "SEC");
-                            mv.MessageGroupName = Properties.Resources.textOverview;
-                            vViolations.Add(mv);
-                        }
+                    if(!isValidOutgoing)
+                    {
+                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Kiel Canal outgoing implausible (ETD / ETA ports)!", null, "Kiel Canal timing", null, "SEC");
+                        mv.MessageGroupName = Properties.Resources.textOverview;
+                        vViolations.Add(mv);
                     }
                 }
             }
@@ -1231,133 +1212,19 @@ namespace ENI2
 
             #endregion
 
-            #region WAS special max capa rules regarding next port
+            #endregion
 
+            foreach (MessageError me in vErrors)
             {
-                string wasMessageGroup = this.MessageGroupForMessage(wasMessage);
-
-                // see WAS-Regulation.docx in parent projects misc folder
-                if ((noanodMessage?.Elements.Count > 0) && wasMessage?.Elements.Count > 0)
-                {
-                    NOA_NOD noa_nod = noanodMessage.Elements[0] as NOA_NOD;
-                    WAS was = wasMessage.Elements[0] as WAS;
-
-                    bool isSpecialNextPort = RuleEngine.IsSpecialNextPort(noa_nod.NextPort);
-
-                    if (isSpecialNextPort)
-                    {
-                        foreach (Waste waste in was.Waste)
-                        {
-                            switch (waste.WasteType)
-                            {
-                                case 101:
-                                case 102:
-                                case 103:
-                                case 104:
-                                case 105:
-                                case 401:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.5)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                                case 501:
-                                case 502:
-                                case 503:
-                                case 504:
-                                case 505:
-                                case 506:
-                                case 507:
-                                case 508:
-                                case 509:
-                                case 510:
-                                case 511:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.25)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                                case 601:
-                                case 602:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.75)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                            }
-                        }
-                    }
-                    else
-                    {
-                        foreach (Waste waste in was.Waste)
-                        {
-                            switch (waste.WasteType)
-                            {
-                                case 101:
-                                case 102:
-                                case 103:
-                                case 104:
-                                case 105:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.25)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                                case 401:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.5)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                                case 501:
-                                case 502:
-                                case 503:
-                                case 504:
-                                case 505:
-                                case 506:
-                                case 507:
-                                case 508:
-                                case 509:
-                                case 510:
-                                case 511:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.2)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                                case 601:
-                                case 602:
-                                    if (waste.WasteAmountRetained_MTQ > waste.WasteCapacity_MTQ * 0.25)
-                                    {
-                                        MessageViolation mv = RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Acc. to EU Regulation 2022/89 the amount retained on board is noticeably", null, "Waste", waste.Identifier, was.Tablename);
-                                        mv.MessageGroupName = wasMessageGroup;
-                                        vViolations.Add(mv);
-                                    }
-                                    break;
-                            }
-                        }
-                    }
-                }
+                this.highlightService.HighlightError(me, this.GetContainerForMessageGroupName(me.MessageGroupName));
+            }
+            foreach (MessageViolation mv in vViolations)
+            {
+                this.highlightService.HighlightViolation(mv, this.GetContainerForMessageGroupName(mv.MessageGroupName));
             }
 
-            #endregion
-
-            #endregion
-
             // "neue" regelbasierte Validierung: Hier werden die einzelnen Regeln geprüft.
-            bsmd.database.ValidationRule.PrepareNameLookupDict(this.Core, messagesSnapshot);
+            bsmd.database.ValidationRule.PrepareNameLookupDict(this.Core, this._messages);
 
             List<bsmd.database.ValidationRule> validationRules = DBManager.Instance.GetValidationRules();
 
@@ -1384,94 +1251,10 @@ namespace ENI2
                 }
             }
 
-            
-            // Recompute per-message counts after all global validations
-            Dictionary<Message, MessageValidationCounts> counts = new Dictionary<Message, MessageValidationCounts>();
-
-            int assignViolationCounter = 0;
-            int assignErrorCounter = 0;
-
-            List<MessageViolation> tmpVList = new List<MessageViolation>(vViolations);
-            List<MessageError> tmpEList = new List<MessageError>(vErrors);
-
-            foreach (Message aMessage in messagesSnapshot)
-            {
-                counts[aMessage] = new MessageValidationCounts();
-                counts[aMessage].ErrorCount = tmpEList.Count(me => me.NotificationClass == aMessage.MessageNotificationClassDisplay); // generic
-                // special cases
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.WAS_RCPT) && (me.NotificationClass == "WasteReceived"));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IMDGPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IGCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IBCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IMSBCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "MARPOL_Annex_I_Position") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IMDGPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IGCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IBCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IMSBCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "MARPOL_Annex_I_Position") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.WAS) && (me.NotificationClass == "Waste"));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.SEC) && (me.NotificationClass == "LastTenPortFacilitiesCalled"));
-                counts[aMessage].ErrorCount += tmpEList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.SEC) && (me.NotificationClass == "ShipToShipActivitiesDuringLastTenPortFacilitiesCalled"));
-
-                if (counts[aMessage].ErrorCount == 0) counts[aMessage].ErrorCount = null; // set to empty if nothing counted
-                assignErrorCounter += counts[aMessage].ErrorCount ?? 0;
-
-                counts[aMessage].ViolationCount = vViolations.Count(mv => mv.NotificationClass == aMessage.MessageNotificationClassDisplay); // generic
-                // special cases
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.WAS_RCPT) && (me.NotificationClass == "WasteReceived"));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IMDGPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IGCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IBCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "IMSBCPosition") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZA) && (me.NotificationClass == "MARPOL_Annex_I_Position") && me.MessageGroupName.Contains("arrival", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IMDGPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IGCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IBCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "IMSBCPosition") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.HAZD) && (me.NotificationClass == "MARPOL_Annex_I_Position") && me.MessageGroupName.Contains("departure", StringComparison.OrdinalIgnoreCase));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.WAS) && (me.NotificationClass == "Waste"));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.SEC) && (me.NotificationClass == "LastTenPortFacilitiesCalled"));
-                counts[aMessage].ViolationCount += tmpVList.Count(me => (aMessage.MessageNotificationClass == Message.NotificationClass.SEC) && (me.NotificationClass == "ShipToShipActivitiesDuringLastTenPortFacilitiesCalled"));
-
-                if (counts[aMessage].ViolationCount == 0) counts[aMessage].ViolationCount = null;
-
-                assignViolationCounter += counts[aMessage].ViolationCount ?? 0;
-            }
-            
-
-            Trace.WriteLine(string.Format("Unassigned errors: {0}, unassigned violations: {1}", vErrors.Count - assignErrorCounter, vViolations.Count - assignViolationCounter));
-            
-
-            return new ValidationResult(vViolations, vErrors, counts);
-        }
-
-        
-
-        private void ApplyValidationResult(ValidationResult result, bool showMessages)
-        {
-            // TODO: clear highlighting
-            foreach (KeyValuePair<Message, MessageValidationCounts> entry in result.Counts)
-            {
-                Message aMessage = entry.Key;
-                MessageValidationCounts messageCounts = entry.Value;
-                aMessage.ErrorCount = messageCounts.ErrorCount;
-                aMessage.ViolationCount = messageCounts.ViolationCount;                
-            }
-
-            foreach (MessageError me in result.Errors)
-            {
-                this.highlightService.HighlightError(me, this.GetContainerForMessageGroupName(me.MessageGroupName));
-            }
-            foreach (MessageViolation mv in result.Violations)
-            {
-                this.highlightService.HighlightViolation(mv, this.GetContainerForMessageGroupName(mv.MessageGroupName));
-            }
-
             if (showMessages)
             {
                 // Show error and violation dialog
-                if (result.Errors.Count > 0)
+                if (vErrors.Count > 0)
                 {
                     if(this._errorListDialog == null)
                     {
@@ -1486,10 +1269,10 @@ namespace ENI2
                     {
                         this._errorListDialog.BringUp();
                     }
-                    this._errorListDialog.Errors = result.Errors;
+                    this._errorListDialog.Errors = vErrors;
                 }
 
-                if (result.Violations.Count > 0)
+                if (vViolations.Count > 0)
                 {
                     if(this._violationListDialog == null)
                     {
@@ -1504,62 +1287,15 @@ namespace ENI2
                     {
                         this._violationListDialog.BringUp();
                     }
-                    _violationListDialog.Violations = result.Violations;
+                    _violationListDialog.Violations = vViolations;
                 }                
 
-                if((result.Errors.Count == 0) && (result.Violations.Count == 0))
+                if((vErrors.Count == 0) && (vViolations.Count == 0))
                 {
                     MessageBox.Show(Properties.Resources.textValidationOK, Properties.Resources.textValidation, MessageBoxButton.OK, MessageBoxImage.Information);
                 }
+
             }
-
-            if (controlCache.TryGetValue(Properties.Resources.textOverview, out DetailBaseControl overviewControl) &&
-                overviewControl is OverViewDetailControl ovdc)
-            {
-                ovdc.RefreshMessageGrid();
-            }
-        }
-
-        private void ApplyCrewEffectsWarningSuppression()
-        {
-            // 4.1.23 no CREW effects warning for DE
-            Message crewaMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWA);
-            Message crewdMessage = _messages.Find(message => message.MessageNotificationClass == Message.NotificationClass.CREWD);
-
-            if (crewaMessage != null)
-            {
-                MessageViolation mv = crewaMessage.ViolationList.Find((x) => x.PropertyName.Equals("Effects") && (x.ViolationCode == (int)ValidationCode.TRUNCATE));
-                if ((mv != null) && !Core.IsDK)
-                    crewaMessage.ViolationList.Remove(mv);
-            }
-
-            if(crewdMessage != null)
-            {
-                MessageViolation mvd = crewdMessage.ViolationList.Find((x) => x.PropertyName.Equals("Effects") && (x.ViolationCode == (int)ValidationCode.TRUNCATE));
-                if ((mvd != null) && !Core.IsDK)
-                    crewdMessage.ViolationList.Remove(mvd);
-            }
-        }
-
-        private sealed class ValidationResult
-        {
-            internal ValidationResult(List<MessageViolation> violations, List<MessageError> errors, Dictionary<Message, MessageValidationCounts> counts)
-            {
-                Violations = violations;
-                Errors = errors;
-                Counts = counts;
-            }
-
-            internal List<MessageViolation> Violations { get; }
-            internal List<MessageError> Errors { get; }
-            internal Dictionary<Message, MessageValidationCounts> Counts { get; }
-        }
-
-        private sealed class MessageValidationCounts
-        {
-            internal int? ErrorCount { get; set; }
-            internal int? ViolationCount { get; set; }
-            internal int? PositionViolationCount { get; set; }
         }
 
         private void _errorListDialog_RefreshClicked()

ENI2/DetailViewControls/BorderPoliceDetailControl.xaml.cs

@@ -1051,8 +1051,7 @@ namespace ENI2.DetailViewControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present
@@ -1122,8 +1121,7 @@ namespace ENI2.DetailViewControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present
@@ -1194,8 +1192,7 @@ namespace ENI2.DetailViewControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1);
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present
@@ -1271,8 +1268,7 @@ namespace ENI2.DetailViewControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1);
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present

ENI2/DetailViewControls/OverViewDetailControl.xaml.cs

@@ -370,11 +370,6 @@ namespace ENI2.DetailViewControls
             this.Core.IsDirty = false; // ist ja schon gespeichert..
         }
 
-        internal void RefreshMessageGrid()
-        {
-            this.dataGridMessages?.Items?.Refresh();
-        }
-
         #endregion
 
         #region private methods

ENI2/DetailViewControls/WasteDetailControl.xaml.cs

@@ -5,7 +5,6 @@
 using bsmd.database;
 using ClosedXML.Excel;
 using ENI2.EditControls;
-using ENI2.Excel;
 using ENI2.Util;
 using Microsoft.Win32;
 using System;
@@ -480,13 +479,86 @@ namespace ENI2.DetailViewControls
 
         private void buttonImportFromExcel_Click(object sender, RoutedEventArgs e)
         {
-            int importWasteListCnt = ExcelLocalImportHelper.ImportWaste(_was);
-
-            if (importWasteListCnt > 0)
+            OpenFileDialog ofd = new OpenFileDialog();
+            ofd.Filter = "Excel Files|*.xls;*.xlsx";
+            if (ofd.ShowDialog() ?? false)
             {
-                this.dataGridWaste.Items.Refresh();
-                this.SublistElementChanged(Message.NotificationClass.WAS);
-                MessageBox.Show(String.Format(Properties.Resources.textWasteImported, importWasteListCnt), Properties.Resources.textCaptionInformation, MessageBoxButton.OK, MessageBoxImage.Information);
+                try
+                {
+                    using (var workbook = new XLWorkbook(ofd.FileName))
+                    {
+                        var worksheet = workbook.Worksheet(1); // Get first worksheet
+                        var rows = worksheet.RangeUsed().RowsUsed().Skip(3); // Skip first three rows
+
+                        List<Waste> importWasteList = new List<Waste>();
+
+                        int cnt = 0;
+                        object o = null;
+
+                        // Diese Funktion kann das "alte" Sheet Format nicht mehr einlesen!
+
+                        foreach (var row in rows)
+                        {
+                            if (cnt >= 35) break; // Maximum 35 rows
+
+                            if (worksheet.RangeUsed().ColumnCount() < 9)
+                            {
+                                throw new InvalidDataException("Sheet must have 9 Columns of data");
+                            }
+
+                            if (!row.Cell(2).IsEmpty()) o = row.Cell(2).Value; else o = null;
+                            if ((o != null) && Int32.TryParse(o.ToString(), out int wasteType))
+                            {
+                                Waste waste = _was.GetWasteForType(wasteType);
+                                if (waste == null)
+                                {
+                                    waste = new Waste();
+                                    waste.WasteType = wasteType;
+                                    waste.WAS = this._was;
+                                    waste.IsDirty = true;
+                                    waste.Identifier = Waste.GetNewIdentifier(this._was.Waste);
+                                    this._was.Waste.Add(waste);
+                                }
+                                else
+                                {
+                                    waste.IsDirty = true;
+                                }
+
+                                if (!row.Cell(5).IsEmpty()) waste.WasteDescription = row.Cell(5).GetString();
+                                if (waste.WasteDescription.IsNullOrEmpty())
+                                    waste.WasteDescription = "-";
+
+                                if (!row.Cell(6).IsEmpty()) o = row.Cell(6).Value; else o = null;
+                                if (o != null) waste.WasteDisposalAmount_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(7).IsEmpty()) o = row.Cell(7).Value; else o = null;
+                                if (o != null) waste.WasteCapacity_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(8).IsEmpty()) o = row.Cell(8).Value; else o = null;
+                                if (o != null) waste.WasteAmountRetained_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(9).IsEmpty()) waste.WasteDisposalPort = row.Cell(9).GetString().ToUpper();
+
+                                if (!row.Cell(10).IsEmpty()) o = row.Cell(10).Value; else o = null;
+                                if (o != null) waste.WasteAmountGeneratedTillNextPort_MTQ = Convert.ToDouble(o);
+
+                                importWasteList.Add(waste);
+                                cnt++;
+                            }
+                        }
+
+                        if (importWasteList.Count > 0)
+                        {
+                            this.dataGridWaste.Items.Refresh();
+                            this.SublistElementChanged(Message.NotificationClass.WAS);
+                            MessageBox.Show(String.Format(Properties.Resources.textWasteImported, importWasteList.Count), Properties.Resources.textCaptionInformation, MessageBoxButton.OK, MessageBoxImage.Information);
+                        }
+                    }
+                }
+                catch (Exception ex)
+                {
+                    MessageBox.Show("Error reading Excel: " + ex.Message, Properties.Resources.textCaptionError, MessageBoxButton.OK, MessageBoxImage.Error);
+                }
             }
         }
 

ENI2/ENI2.csproj

@@ -37,7 +37,7 @@
     <CreateWebPageOnPublish>true</CreateWebPageOnPublish>
     <WebPage>publish.html</WebPage>
     <ApplicationRevision>2</ApplicationRevision>
-    <ApplicationVersion>7.2.14.2</ApplicationVersion>
+    <ApplicationVersion>7.2.13.2</ApplicationVersion>
     <UseApplicationTrust>false</UseApplicationTrust>
     <CreateDesktopShortcut>true</CreateDesktopShortcut>
     <PublishWizardCompleted>true</PublishWizardCompleted>

ENI2/Excel/ExcelBase.cs

@@ -9,7 +9,6 @@ using System.Globalization;
 using System.Text.RegularExpressions;
 using System.Drawing;
 using System.Linq;
-using System.IO;
 
 namespace ENI2.Excel
 {
@@ -23,7 +22,6 @@ namespace ENI2.Excel
         protected CountryMode _countryMode = CountryMode.DE;
 
         protected XLWorkbook _workBook;
-        protected FileStream _workBookStream;
         protected Dictionary<string, IXLDefinedName> _nameDict;
         protected ILog _log;
 
@@ -103,12 +101,6 @@ namespace ENI2.Excel
             }
         }
 
-        protected void OpenWorkbookReadOnly(string path)
-        {
-            _workBookStream = new FileStream(path, FileMode.Open, FileAccess.Read, FileShare.ReadWrite);
-            _workBook = new XLWorkbook(_workBookStream);
-        }
-
         private static double? ParseAnyDouble(string val)
         {
             double? result = null;
@@ -220,11 +212,6 @@ namespace ENI2.Excel
                     _workBook.Dispose();
                     _workBook = null;
                 }
-                if (_workBookStream != null)
-                {
-                    _workBookStream.Dispose();
-                    _workBookStream = null;
-                }
             }
             catch (Exception ex)
             {

ENI2/Excel/ExcelComparer.cs

@@ -53,8 +53,7 @@ namespace ENI2.Excel
             {
                 File.Copy(targetPath, comparisonFileName, true);
 
-                using (var sourceStream = new FileStream(sourcePath, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                using (var sourceWorkbook = new XLWorkbook(sourceStream))
+                using (var sourceWorkbook = new XLWorkbook(sourcePath))
                 using (var comparisonWorkbook = new XLWorkbook(comparisonFileName))
                 {
                     // Es werden Zellen der "used range" miteinander verglichen
@@ -77,7 +76,6 @@ namespace ENI2.Excel
                         {
                             int maxRows = Math.Max(sourceRows, targetRows);
                             int maxCols = Math.Max(sourceCols, targetCols);
-                            bool sheetHasDiffs = false;
 
                             for (int rowidx = 1; rowidx <= maxRows; rowidx++)
                             {
@@ -113,7 +111,6 @@ namespace ENI2.Excel
                                             var cellToHighlight = targetSheet.Cell(rowidx, colidx);
                                             cellToHighlight.Style.Fill.BackgroundColor = diffColor;
                                             counter++;
-                                            sheetHasDiffs = true;
                                         }
                                     }
                                     else if (targetText == null)
@@ -123,7 +120,6 @@ namespace ENI2.Excel
                                             var cellToHighlight = targetSheet.Cell(rowidx, colidx);
                                             cellToHighlight.Style.Fill.BackgroundColor = diffColor;
                                             counter++;
-                                            sheetHasDiffs = true;
                                         }
                                     }
                                     else if ((sourceText != null) && (targetText != null))
@@ -133,16 +129,10 @@ namespace ENI2.Excel
                                             var cellToHighlight = targetSheet.Cell(rowidx, colidx);
                                             cellToHighlight.Style.Fill.BackgroundColor = diffColor;
                                             counter++;
-                                            sheetHasDiffs = true;
                                         }
                                     }
                                 }
                             }
-
-                            if (sheetHasDiffs)
-                            {
-                                targetSheet.SetTabColor(diffColor);
-                            }
                         }
                         else
                         {

ENI2/Excel/ExcelLocalImportHelper.cs

@@ -4,7 +4,6 @@ using Microsoft.Win32;
 using System;
 using System.Collections.Generic;
 using System.IO;
-using System.Linq;
 using System.Windows;
 
 namespace ENI2.Excel
@@ -27,8 +26,7 @@ namespace ENI2.Excel
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1);
                         var rows = worksheet.RangeUsed().RowsUsed();
@@ -146,8 +144,7 @@ namespace ENI2.Excel
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1);
                         var rows = worksheet.RangeUsed().RowsUsed();
@@ -245,89 +242,5 @@ namespace ENI2.Excel
 
         #endregion
 
-        #region Waste from Excel
-
-        public static int ImportWaste(WAS was)
-        {
-            int cnt = 0;
-            OpenFileDialog ofd = new OpenFileDialog();
-            ofd.Filter = "Excel Files|*.xls;*.xlsx";
-            if (ofd.ShowDialog() ?? false)
-            {
-                try
-                {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
-                    {
-                        var worksheet = workbook.Worksheet(1); // Get first worksheet
-                        var rows = worksheet.RangeUsed().RowsUsed().Skip(3); // Skip first three rows
-
-                        List<Waste> importWasteList = new List<Waste>();
-                        
-                        object o = null;
-
-                        // Diese Funktion kann das "alte" Sheet Format nicht mehr einlesen!
-
-                        foreach (var row in rows)
-                        {
-                            if (cnt >= 35) break; // Maximum 35 rows
-
-                            if (worksheet.RangeUsed().ColumnCount() < 9)
-                            {
-                                throw new InvalidDataException("Sheet must have 9 Columns of data");
-                            }
-
-                            if (!row.Cell(2).IsEmpty()) o = row.Cell(2).Value; else o = null;
-                            if ((o != null) && Int32.TryParse(o.ToString(), out int wasteType))
-                            {
-                                Waste waste = was.GetWasteForType(wasteType);
-                                if (waste == null)
-                                {
-                                    waste = new Waste();
-                                    waste.WasteType = wasteType;
-                                    waste.WAS = was;
-                                    waste.IsDirty = true;
-                                    waste.Identifier = Waste.GetNewIdentifier(was.Waste);
-                                    was.Waste.Add(waste);
-                                }
-                                else
-                                {
-                                    waste.IsDirty = true;
-                                }
-
-                                if (!row.Cell(5).IsEmpty()) waste.WasteDescription = row.Cell(5).GetString();
-                                if (waste.WasteDescription.IsNullOrEmpty())
-                                    waste.WasteDescription = "-";
-
-                                if (!row.Cell(6).IsEmpty())
-                                    waste.WasteDisposalAmount_MTQ = row.Cell(6).GetDouble();
-
-                                if (!row.Cell(7).IsEmpty())
-                                    waste.WasteCapacity_MTQ = row.Cell(7).GetDouble();
-
-                                if (!row.Cell(8).IsEmpty()) waste.WasteAmountRetained_MTQ = row.Cell(8).GetDouble();
-
-                                if (!row.Cell(9).IsEmpty())
-                                    waste.WasteDisposalPort = row.Cell(9).GetString().ToUpper();
-
-                                if (!row.Cell(10).IsEmpty())
-                                    waste.WasteAmountGeneratedTillNextPort_MTQ = row.Cell(10).GetDouble();
-
-                                importWasteList.Add(waste);
-                                cnt++;
-                            }
-                        }                        
-                    }
-                }
-                catch (Exception ex)
-                {
-                    MessageBox.Show("Error reading Excel: " + ex.Message, Properties.Resources.textCaptionError, MessageBoxButton.OK, MessageBoxImage.Error);
-                }
-            }
-            return cnt;
-        }
-
-        #endregion
-
     }
 }

ENI2/Excel/ExcelReader.cs

@@ -32,7 +32,7 @@ namespace ENI2.Excel
 
         public ExcelReader(string filePath, bool createNameFields = true)
         {
-            this.OpenWorkbookReadOnly(filePath);
+            this._workBook = new XLWorkbook(filePath);
             if (createNameFields)
                 this.InitNameFields();
 

ENI2/Excel/ExcelWriter.cs

@@ -26,7 +26,7 @@ namespace ENI2.Excel
             if (isRefSheet) filename = @"Excel\Reference_Sheet_DE.xlsx";
 
             string refFilePath = System.IO.Path.Combine(Environment.CurrentDirectory, filename);
-            this.OpenWorkbookReadOnly(refFilePath);
+            this._workBook = new XLWorkbook(refFilePath);
 
             this.InitNameFields();
         }

ENI2/SheetDisplayControls/CrewDepartureControl.xaml.cs

@@ -128,8 +128,7 @@ namespace ENI2.SheetDisplayControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present

ENI2/SheetDisplayControls/CrewPreArrivalControl.xaml.cs

@@ -168,8 +168,7 @@ namespace ENI2.SheetDisplayControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present

ENI2/SheetDisplayControls/PassengerDepartureControl.xaml.cs

@@ -146,8 +146,7 @@ namespace ENI2.SheetDisplayControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present

ENI2/SheetDisplayControls/PassengerPreArrivalControl.xaml.cs

@@ -128,8 +128,7 @@ namespace ENI2.SheetDisplayControls
             {
                 try
                 {
-                    using (var stream = new FileStream(ofd.FileName, FileMode.Open, FileAccess.Read, FileShare.ReadWrite))
-                    using (var workbook = new XLWorkbook(stream))
+                    using (var workbook = new XLWorkbook(ofd.FileName))
                     {
                         var worksheet = workbook.Worksheet(1); // Get first worksheet
                         var rows = worksheet.RangeUsed().RowsUsed().Skip(1); // Skip header row if present

ENI2/SheetDisplayControls/PortControl.xaml.cs

@@ -5,7 +5,6 @@
 using bsmd.database;
 using ClosedXML.Excel;
 using ENI2.EditControls;
-using ENI2.Excel;
 using Microsoft.Win32;
 
 using System;
@@ -515,13 +514,87 @@ namespace ENI2.SheetDisplayControls
 
         private void buttonImportFromExcel_Click(object sender, RoutedEventArgs e)
         {
-            int importWasteListCnt = ExcelLocalImportHelper.ImportWaste(_was);
-
-            if (importWasteListCnt > 0)
+            OpenFileDialog ofd = new OpenFileDialog();
+            ofd.Filter = "Excel Files|*.xls;*.xlsx";
+            if (ofd.ShowDialog() ?? false)
             {
-                this.dataGridWaste.Items.Refresh();
-                this.SublistElementChanged(Message.NotificationClass.WAS);
-                MessageBox.Show(String.Format(Properties.Resources.textWasteImported, importWasteListCnt), Properties.Resources.textCaptionInformation, MessageBoxButton.OK, MessageBoxImage.Information);
+                try
+                {
+                    using (var workbook = new XLWorkbook(ofd.FileName))
+                    {
+                        var worksheet = workbook.Worksheet(1); // Get first worksheet
+                        var rows = worksheet.RangeUsed().RowsUsed().Skip(3); // Skip first three rows
+
+                        List<Waste> importWasteList = new List<Waste>();
+
+                        int cnt = 0;
+
+                        // Diese Funktion kann das "alte" Sheet Format nicht mehr einlesen!
+
+                        foreach (var row in rows)
+                        {
+                            if (cnt >= 35) break; // Maximum 35 rows
+
+                            if (worksheet.RangeUsed().ColumnCount() < 9)
+                            {
+                                throw new InvalidDataException("Sheet must have 9 Columns of data");
+                            }
+
+                            object o = null;
+
+                            if (!row.Cell(2).IsEmpty()) o = row.Cell(2).Value; else o = null;
+                            if ((o != null) && Int32.TryParse(o.ToString(), out int wasteType))
+                            {
+                                Waste waste = _was.GetWasteForType(wasteType);
+                                if (waste == null)
+                                {
+                                    waste = new Waste();
+                                    waste.WasteType = wasteType;
+                                    waste.WAS = this._was;
+                                    waste.IsDirty = true;
+                                    waste.Identifier = Waste.GetNewIdentifier(this._was.Waste);
+                                    this._was.Waste.Add(waste);
+                                }
+                                else
+                                {
+                                    waste.IsDirty = true;
+                                }
+
+                                if (!row.Cell(5).IsEmpty()) waste.WasteDescription = row.Cell(5).GetString();
+                                if (waste.WasteDescription.IsNullOrEmpty())
+                                    waste.WasteDescription = "-";
+
+                                if (!row.Cell(6).IsEmpty()) o = row.Cell(6).Value; else o = null;
+                                if (o != null) waste.WasteDisposalAmount_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(7).IsEmpty()) o = row.Cell(7).Value; else o = null;
+                                if (o != null) waste.WasteCapacity_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(8).IsEmpty()) o = row.Cell(8).Value; else o = null;
+                                if (o != null) waste.WasteAmountRetained_MTQ = Convert.ToDouble(o);
+
+                                if (!row.Cell(9).IsEmpty()) waste.WasteDisposalPort = row.Cell(9).GetString().ToUpper();
+
+                                if (!row.Cell(10).IsEmpty()) o = row.Cell(10).Value; else o = null;
+                                if (o != null) waste.WasteAmountGeneratedTillNextPort_MTQ = Convert.ToDouble(o);
+
+                                importWasteList.Add(waste);
+                                cnt++;
+                            }
+                        }
+
+                        if (importWasteList.Count > 0)
+                        {
+                            this.dataGridWaste.Items.Refresh();
+                            this.SublistElementChanged(Message.NotificationClass.WAS);
+                            MessageBox.Show(String.Format(Properties.Resources.textWasteImported, importWasteList.Count), Properties.Resources.textCaptionInformation, MessageBoxButton.OK, MessageBoxImage.Information);
+                        }
+                    }
+                }
+                catch (Exception ex)
+                {
+                    MessageBox.Show("Error reading Excel: " + ex.Message, Properties.Resources.textCaptionError, MessageBoxButton.OK, MessageBoxImage.Error);
+                }
             }
         }
 

bsmd.ExcelReadService/ExcelReader.cs

@@ -36,23 +36,7 @@ namespace bsmd.ExcelReadService
             this._excelApp.DisplayAlerts = false;
             this._excelWorkbooks = _excelApp.Workbooks;
             
-            this._portcall = _excelWorkbooks.Open(
-                filePath,
-                UpdateLinks: 0,
-                ReadOnly: true,
-                Format: 5,
-                Password: "",
-                WriteResPassword: "",
-                IgnoreReadOnlyRecommended: true,
-                Origin: XlPlatform.xlWindows,
-                Delimiter: "",
-                Editable: false,
-                Notify: false,
-                Converter: 0,
-                AddToMru: false,
-                Local: false,
-                CorruptLoad: false);
-            this._portcall.ChangeFileAccess(XlFileAccess.xlReadOnly);
+            this._portcall = _excelWorkbooks.Open(filePath, 0, true, 5, "", "", false, XlPlatform.xlWindows, "", false, false, 0, false, false, false);
             _nameDict = new Dictionary<string, Name>();
             int bookCnt = 0;
             foreach(Name name in _portcall.Names)

bsmd.database/Message.cs

@@ -431,6 +431,11 @@ namespace bsmd.database
         /// </summary>
         public int? ViolationCount { get; set; }
 
+        /// <summary>
+        /// Number of violations during last validation that have the "identifier" set and are thus detected violations
+        /// from underlying list elements
+        /// </summary>
+        public int? PositionViolationCount { get; set; }
 
         /// <summary>
         /// Number of errors during last validation

bsmd.database/Properties/AssemblyProductInfo.cs

@@ -2,6 +2,6 @@
 
 [assembly: AssemblyCompany("schick Informatik")]
 [assembly: AssemblyProduct("BSMD NSW interface")]
-[assembly: AssemblyInformationalVersion("7.2.14")]
+[assembly: AssemblyInformationalVersion("7.2.13")]
 [assembly: AssemblyCopyright("Copyright ©  2014-2025 schick Informatik")]
 [assembly: AssemblyTrademark("")]

bsmd.database/Properties/AssemblyProjectInfo.cs

@@ -1,4 +1,4 @@
 using System.Reflection;
 
-[assembly: AssemblyVersion("7.2.14.*")]
+[assembly: AssemblyVersion("7.2.13.*")]
 

bsmd.database/RuleEngine.cs

@@ -97,22 +97,6 @@ namespace bsmd.database
 
         #endregion
 
-        #region for extra waste validation
-
-        private static readonly HashSet<string> SpecialNextPortPrefixes = new HashSet<string>
-        {
-            "BE", "BG", "DK", "DE", "EE", "FI", "FR", "GR", "IR", "IT",
-            "HR", "LV", "LT", "LU", "MT", "NL", "AT", "PL", "PT", "RO",
-            "SE", "SK", "SL", "ES", "CZ", "HU", "CY", "NO", "IS", "GB", "GI"
-        };
-
-        private static readonly HashSet<string> SpecialNextPortExact = new HashSet<string>
-        {
-            "RUPRI", "RUULU", "RULED", "RUBLT", "RUKGD", "RUVYS"
-        };
-
-        #endregion
-
         public enum LocodeMode
         {
             STANDARD,
@@ -147,20 +131,6 @@ namespace bsmd.database
         public static LocodeValidHandler LocodeChecker { get { return _locodeChecker; } }
         public static NationalityValidHandler NationalityChecker { get { return _nationalityChecker; } }
 
-        /// <summary>
-        /// Used to test for special next port values for waste messages
-        /// </summary>
-        /// <param name="nextPort">a locode</param>
-        /// <returns>true if the next port is a special waste port</returns>
-        public static bool IsSpecialNextPort(string nextPort)
-        {
-            if (string.IsNullOrEmpty(nextPort) || nextPort.Length < 2)
-                return false;
-
-            return SpecialNextPortExact.Contains(nextPort) ||
-                   SpecialNextPortPrefixes.Contains(nextPort.Substring(0, 2));
-        }
-
         #region public static property validation
 
         public static void RegisterLocodeChecker(LocodeValidHandler handler) { _locodeChecker = handler; }

bsmd.database/Waste.cs

@@ -266,13 +266,11 @@ namespace bsmd.database
             if (this.WasteAmountGeneratedTillNextPort_MTQ >= 10000)
                 errors.Add(RuleEngine.CreateError(ValidationCode.IMPLAUSIBLE, "Waste generated till next port too high", null, this.Title, this.Identifier, this.Tablename));
 
-            // Removed this for version 7.2.14 (new rules depending on next port implemented in ENI / DetailRootControl.cs)
+            if(this.WasteDisposalAmount_MTQ > this.WasteCapacity_MTQ)
+                violations.Add(RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Disposal greater than capacity!", null, this.Title, this.Identifier, this.Tablename));
 
-            // if(this.WasteDisposalAmount_MTQ > this.WasteCapacity_MTQ)
-            //     violations.Add(RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Disposal greater than capacity!", null, this.Title, this.Identifier, this.Tablename));
-
-            // if((this.WasteAmountGeneratedTillNextPort_MTQ + this.WasteAmountRetained_MTQ) > this.WasteCapacity_MTQ)
-            //    violations.Add(RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Waste generated+retained greater than capacity!", null, this.Title, this.Identifier, this.Tablename));
+            if((this.WasteAmountGeneratedTillNextPort_MTQ + this.WasteAmountRetained_MTQ) > this.WasteCapacity_MTQ)
+                violations.Add(RuleEngine.CreateViolation(ValidationCode.IMPLAUSIBLE, "Waste generated+retained greater than capacity!", null, this.Title, this.Identifier, this.Tablename));
         }
 
         #endregion