Commit Graph

261 Commits

Author SHA1 Message Date
scopesorting
d363c3554b adapting shipcall, times and user to include ValidationError (marshmallow). Adjusting the Schemas for User, Times and Shipcall to be validated with additional input validators. Creating a set of tests for the input validations. 2023-12-07 12:01:41 +01:00
scopesorting
82309a53d6 bugfix of 0004A and B, where the tide window may have deviated by few seconds, so the wrong state would be concluded. 2023-12-07 11:54:37 +01:00
scopesorting
c0a9557584 changing 'exit' with sys.exit to avoid 'NameError' for the exit call 2023-12-07 09:12:04 +01:00
scopesorting
7bcce95b36 Solving: RemovedInMarshmallow4Warning: Passing field metadata as keyword arguments is deprecated. Use the explicit argument instead. Additional metadata: {'Required': False} 2023-12-07 09:10:52 +01:00
scopesorting
dd8530c1ad Merge branch 'develop' of github.com:puls200/brecal into feature/input_validation
merging develop and novel branch
2023-12-07 08:18:54 +01:00
faae0cb6f0
Merge pull request #20 from puls200/bugfix/pierside
Merging all Go-Live fixes back into develop
2023-12-01 09:48:27 +02:00
scopesorting
ad593ff2a2 more concise evaluation messages for 0001. Adding newlines (works on Windows) when multiple evaluation messages are shown. Properly adding the ShipcallType filters for each rule (whether incoming, outgoing or shifting). Added a regular expression to abbreviate an evaluation message when 512 characters are exceeded. 2023-12-01 09:44:22 +02:00
scopesorting
fce8ce0c68 changing the ParticipantType to an IntFlag, so multiple roles are possible. Adapting every validation rule (0001, 0003, 0004, 0005), which may be affected by this change. Changing the filter for a participant type to properly include the change. Changing the pier_side rule (0006B), which uses the shipcall and times_terminal. New shipcalls should now be evaluated properly, unless no participant is assigned at all. If the ladder case can occur, the validation rules 0001N+0001O will be added (held back for now). 2023-12-01 09:44:09 +02:00
scopesorting
6f9b4a6b5a removing verbosity in validation rule functions, and returning 'None', when a selected times dataframe is empty. In case of empty results, the function now properly computes the delta towards a query time and returns YELLOW, when a violation is observed. This should finally fix the bugs for 0001 A-M 2023-12-01 09:43:49 +02:00
scopesorting
9a12d74e77 updating validation rules 0001 A-M. Instead of filtering by times_df (which may not exist), the rules make use of the shipcall_participant_map. When one of the participants in a rule is not assigned, no violation is observed. When there are multiple entries of a participant (due to an input bug), the function still verifies properly. When critical time is observed, and there is not yet an entry for the respective key time, there will be a 'yellow' state. 2023-12-01 09:43:31 +02:00
scopesorting
9f61e2af38 updating check_time_delta_violation_query_time_to_now: no longer ignoring events of the past (delta<=0) 2023-12-01 09:43:17 +02:00
scopesorting
4859ff6803 ensuring that len(df_times) always works. Preventing 'None' from occuring 2023-12-01 09:42:48 +02:00
scopesorting
0a9ba0b381 more concise evaluation messages for 0001. Adding newlines (works on Windows) when multiple evaluation messages are shown. Properly adding the ShipcallType filters for each rule (whether incoming, outgoing or shifting). Added a regular expression to abbreviate an evaluation message when 512 characters are exceeded. 2023-11-30 17:34:44 +01:00
scopesorting
dc79f05b8b changing the ParticipantType to an IntFlag, so multiple roles are possible. Adapting every validation rule (0001, 0003, 0004, 0005), which may be affected by this change. Changing the filter for a participant type to properly include the change. Changing the pier_side rule (0006B), which uses the shipcall and times_terminal. New shipcalls should now be evaluated properly, unless no participant is assigned at all. If the ladder case can occur, the validation rules 0001N+0001O will be added (held back for now). 2023-11-30 15:53:42 +01:00
scopesorting
8e9be1eae5 Merge branch 'bugfix/header_but_missing_times' of github.com:puls200/brecal into bugfix/header_but_missing_times 2023-11-29 15:21:43 +01:00
scopesorting
d47f85ea44 removing verbosity in validation rule functions, and returning 'None', when a selected times dataframe is empty. In case of empty results, the function now properly computes the delta towards a query time and returns YELLOW, when a violation is observed. This should finally fix the bugs for 0001 A-M 2023-11-29 15:21:20 +01:00
c6a31390e7 helper commit to let this run in test system 2023-11-29 12:29:32 +02:00
scopesorting
e884b20c39 updating validation rules 0001 A-M. Instead of filtering by times_df (which may not exist), the rules make use of the shipcall_participant_map. When one of the participants in a rule is not assigned, no violation is observed. When there are multiple entries of a participant (due to an input bug), the function still verifies properly. When critical time is observed, and there is not yet an entry for the respective key time, there will be a 'yellow' state. 2023-11-29 08:52:37 +01:00
scopesorting
ecdf66bff2 updating check_time_delta_violation_query_time_to_now: no longer ignoring events of the past (delta<=0) 2023-11-28 16:48:20 +01:00
scopesorting
834da84786 minot adjustments & refactoring 2023-11-28 16:49:16 +02:00
scopesorting
8027620f22 fixing the 'KeyError' when using an empty times dataframe. Returning 'green' 2023-11-28 16:48:53 +02:00
c36e913472 added trace output and fixed a bug when saving shipcalls without times 2023-11-28 16:48:16 +02:00
scopesorting
287224eeb4 ensuring that len(df_times) always works. Preventing 'None' from occuring 2023-11-28 14:49:40 +01:00
scopesorting
210252df22 minot adjustments & refactoring 2023-11-28 14:26:38 +01:00
scopesorting
c064556668 fixing the 'KeyError' when using an empty times dataframe. Returning 'green' 2023-11-28 14:17:07 +01:00
adaef94854 added trace output and fixed a bug when saving shipcalls without times 2023-11-28 11:23:46 +01:00
81a45f57cf Catch exception if one occurrs during saving 2023-11-27 17:26:37 +01:00
2b43dc49d9 extended gitignore for local flask 2023-11-27 14:37:23 +01:00
c3f8759c70 fixed error in publish xml 2023-11-26 18:08:38 +01:00
131528021d set everything to blue, meaning prod version 1.0.0 2023-11-26 17:37:31 +01:00
5b2d6db5d3 set everything to red, meaning test version 1.0.0 2023-11-26 17:05:32 +01:00
8d63fece15 Version bump to 1.0.0.0 2023-11-25 16:01:03 +01:00
56ade40aef fixed creating new shipcalls and cleaned up logon error message display 2023-11-25 12:15:38 +01:00
5c6d41470c created 0.9.7 version with some minor fixes 2023-11-25 11:39:45 +01:00
721baa3a06 moved schedule import after venv sitepackage path set 2023-11-22 10:48:27 +01:00
66bfd326cc
Merge pull request #18 from puls200/feature/update_shipcalls_routine
Feature/update shipcalls routine
2023-11-22 10:36:34 +01:00
9b5206572a
Merge pull request #16 from puls200/feature/hotfix_20231114
Feature/hotfix 20231114
2023-11-22 10:30:04 +01:00
scopesorting
fd0efe0046 adding schedule routine jobs, which will be executed in a background thread within WSGI while running the Flask application. 2023-11-21 12:47:04 +01:00
scopesorting
9346920a97 potentially solving the 'shipcall_id' error log 2023-11-21 11:51:49 +01:00
scopesorting
3cc1591aba potentially correcting 0006A/0006B 2023-11-21 11:41:56 +01:00
scopesorting
a5220fd6f2 refactoring: simplification of error messages. These now stem from a string, which is the function name. Previously, the inspect module was used with a rather complex function call to obtain the method's name. The simplification makes code more readable for future work. 2023-11-20 16:43:27 +01:00
scopesorting
49bbb77624 refactoring a few methods 2023-11-20 16:35:31 +01:00
scopesorting
40dc022b25 fixing np to_list error, which may have caused the evaluation function to stop altogether. 2023-11-20 16:22:58 +01:00
scopesorting
21e9c75781 typo. 2023-11-14 12:07:59 +01:00
scopesorting
c6d1bf30a6 adapting rules 0001-L & 0001-M (times terminal) and 0006-B. However, for 0006-B the provided solution is not verified, as the errors could not be reproduced locally. 2023-11-14 12:06:39 +01:00
fd5bd76db2
Merge pull request #15 from puls200/feature/hotfix_20231110
Feature/hotfix 20231110
2023-11-10 18:07:12 +01:00
scopesorting
e9aace6268 creating stub objects for every single validation function. Unit tests are created for each function to check whether they return 'GREEN' whenever no violation is expected, or 'YELLOW'/'RED' when a rule violation is artificially forced. The test framework now successfully runs 116 unit tests. Adapted some validation functions, applied refactoring and solved potential obstacles along the way. At least from the perspective of unit tests, every function now works as expected. 2023-11-10 17:59:08 +01:00
scopesorting
b2cde8b6f5 correcting the open issues from 09.11.2023 (0001 A-M was previously commited, 0006A+B are corrected herein) 2023-11-10 17:50:01 +01:00
9d61b95378 Version bump to 0.9.6 2023-11-10 14:36:25 +01:00
09623f1442 bugfixes and small improvements for 0.9.5 test results 2023-11-10 14:13:06 +01:00